From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] xfs: prevent stack overflows from page cache allocation Date: Fri, 25 Oct 2013 08:24:48 +1100 Message-ID: <20131024212448.GW2797@dastard> References: <1382585110-1796-1-git-send-email-david@fromorbit.com> <20131024084803.GA28144@infradead.org> <20131024103751.GS2797@dastard> <20131024154220.GA19055@infradead.org> <20131024164115.GU1935@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Ben Myers Return-path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:47275 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506Ab3JXVYw (ORCPT ); Thu, 24 Oct 2013 17:24:52 -0400 Content-Disposition: inline In-Reply-To: <20131024164115.GU1935@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 24, 2013 at 11:41:15AM -0500, Ben Myers wrote: > Hey, > > On Thu, Oct 24, 2013 at 08:42:20AM -0700, Christoph Hellwig wrote: > > On Thu, Oct 24, 2013 at 09:37:51PM +1100, Dave Chinner wrote: > > > Sure, if you want to. But doing that shouldn't prevent this fix from > > > being committed in the mean time, especially as other filesystems > > > already use this method for avoiding these problems. > > > > I'd much prefer aiming for the proper fix first. If for some reason we > > can't get it done in time the workaround can be applied. > > Dave probably has a customer waiting on this. Obviously. And being a kernel where we have a fixed ABI, we can't backport any fix that changes core code. > If pulling this in will make a > proper fix more difficult to do I can understand keeping the patch out. It doesn't make a proper fix any harder - removing 2 lines of code is trivial. > Otherwise, can't we just remove this along with the other filesystems' > equivalent code when the proper fix is committed? Yes, we can. Cheers, Dave. -- Dave Chinner david@fromorbit.com