From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Ben Myers <bpm@sgi.com>, Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: prevent stack overflows from page cache allocation
Date: Fri, 25 Oct 2013 04:29:34 -0700 [thread overview]
Message-ID: <20131025112934.GA1585@infradead.org> (raw)
In-Reply-To: <20131024212448.GW2797@dastard>
On Fri, Oct 25, 2013 at 08:24:48AM +1100, Dave Chinner wrote:
> > > I'd much prefer aiming for the proper fix first. If for some reason we
> > > can't get it done in time the workaround can be applied.
> >
> > Dave probably has a customer waiting on this.
>
> Obviously. And being a kernel where we have a fixed ABI, we can't
> backport any fix that changes core code.
No one is trying to tell you what to ship to your customers. That
doesn't mean we should aim for the right fix upstream.
I don't really mind pushing patches like yours as a last resort when
dealing with unrepsonsive or disagreeing maintainers like we had to do
in the past, but trying to push the workaround without even attemping
the proper fix is a bit sad.
next prev parent reply other threads:[~2013-10-25 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1382585110-1796-1-git-send-email-david@fromorbit.com>
2013-10-24 8:48 ` [PATCH] xfs: prevent stack overflows from page cache allocation Christoph Hellwig
2013-10-24 10:37 ` Dave Chinner
2013-10-24 15:42 ` Christoph Hellwig
2013-10-24 16:41 ` Ben Myers
2013-10-24 21:24 ` Dave Chinner
2013-10-25 11:29 ` Christoph Hellwig [this message]
2013-10-27 9:04 ` Dave Chinner
2013-10-28 9:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025112934.GA1585@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).