From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] xfs: prevent stack overflows from page cache allocation Date: Fri, 25 Oct 2013 04:29:34 -0700 Message-ID: <20131025112934.GA1585@infradead.org> References: <1382585110-1796-1-git-send-email-david@fromorbit.com> <20131024084803.GA28144@infradead.org> <20131024103751.GS2797@dastard> <20131024154220.GA19055@infradead.org> <20131024164115.GU1935@sgi.com> <20131024212448.GW2797@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ben Myers , Christoph Hellwig , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Dave Chinner Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:56243 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691Ab3JYL3g (ORCPT ); Fri, 25 Oct 2013 07:29:36 -0400 Content-Disposition: inline In-Reply-To: <20131024212448.GW2797@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 25, 2013 at 08:24:48AM +1100, Dave Chinner wrote: > > > I'd much prefer aiming for the proper fix first. If for some reason we > > > can't get it done in time the workaround can be applied. > > > > Dave probably has a customer waiting on this. > > Obviously. And being a kernel where we have a fixed ABI, we can't > backport any fix that changes core code. No one is trying to tell you what to ship to your customers. That doesn't mean we should aim for the right fix upstream. I don't really mind pushing patches like yours as a last resort when dealing with unrepsonsive or disagreeing maintainers like we had to do in the past, but trying to push the workaround without even attemping the proper fix is a bit sad.