* [PATCH] dcache: fix outdated DCACHE_NEED_LOOKUP comment
@ 2013-10-25 15:59 J. Bruce Fields
2013-10-25 16:03 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2013-10-25 15:59 UTC (permalink / raw)
To: Al Viro; +Cc: linux-fsdevel
From: "J. Bruce Fields" <bfields@redhat.com>
The DCACHE_NEED_LOOKUP case referred to here was removed with
39e3c9553f34381a1b664c27b0c696a266a5735e "vfs: remove
DCACHE_NEED_LOOKUP".
There are only four real_lookup() callers and all of them pass in an
unhashed dentry just returned from d_alloc.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index e337f45..b83bf27 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1308,8 +1308,8 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
}
/*
- * Call i_op->lookup on the dentry. The dentry must be negative but may be
- * hashed if it was pouplated with DCACHE_NEED_LOOKUP.
+ * Call i_op->lookup on the dentry. The dentry must be negative and
+ * unhashed.
*
* dir->d_inode->i_mutex must be held
*/
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dcache: fix outdated DCACHE_NEED_LOOKUP comment
2013-10-25 15:59 [PATCH] dcache: fix outdated DCACHE_NEED_LOOKUP comment J. Bruce Fields
@ 2013-10-25 16:03 ` J. Bruce Fields
2013-10-25 16:19 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2013-10-25 16:03 UTC (permalink / raw)
To: Al Viro; +Cc: linux-fsdevel
Also added to the "for-viro" branch at:
git://linux-nfs.org/~bfields/linux.git for-viro
Which now includes:
- the delegation patches
- 32/64-bit filehandle lookup fix
- 4 dcache patches fixing some uses of DCACHE_DISCONECTED.
All previously posted.
--b.
On Fri, Oct 25, 2013 at 11:59:15AM -0400, bfields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> The DCACHE_NEED_LOOKUP case referred to here was removed with
> 39e3c9553f34381a1b664c27b0c696a266a5735e "vfs: remove
> DCACHE_NEED_LOOKUP".
>
> There are only four real_lookup() callers and all of them pass in an
> unhashed dentry just returned from d_alloc.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
> fs/namei.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index e337f45..b83bf27 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1308,8 +1308,8 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
> }
>
> /*
> - * Call i_op->lookup on the dentry. The dentry must be negative but may be
> - * hashed if it was pouplated with DCACHE_NEED_LOOKUP.
> + * Call i_op->lookup on the dentry. The dentry must be negative and
> + * unhashed.
> *
> * dir->d_inode->i_mutex must be held
> */
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-25 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-25 15:59 [PATCH] dcache: fix outdated DCACHE_NEED_LOOKUP comment J. Bruce Fields
2013-10-25 16:03 ` J. Bruce Fields
2013-10-25 16:19 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).