From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: prevent stack overflows from page cache allocation
Date: Mon, 28 Oct 2013 02:49:57 -0700
Message-ID: <20131028094957.GA19041@infradead.org>
References: <1382585110-1796-1-git-send-email-david@fromorbit.com>
 <20131024084803.GA28144@infradead.org>
 <20131024103751.GS2797@dastard>
 <20131024154220.GA19055@infradead.org>
 <20131024164115.GU1935@sgi.com>
 <20131024212448.GW2797@dastard>
 <20131025112934.GA1585@infradead.org>
 <20131027090409.GA2797@dastard>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, Ben Myers <bpm@sgi.com>,
	xfs@oss.sgi.com
To: Dave Chinner <david@fromorbit.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.9]:37931 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752470Ab3J1Jt6 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 28 Oct 2013 05:49:58 -0400
Content-Disposition: inline
In-Reply-To: <20131027090409.GA2797@dastard>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Thanks for the explanation Dave.  I suspected a generic bug because
the two places mentioned are generic code.  Turns out only XFS and some
cluster filesystems are affected because other filesystems do not call
those under filesystem locks or i_mutex.

But it seem like AOP_FLAG_NOFS is indeed pointless and we should remove it,
in XFS as part of this patch and everywhere else later after talking
to the maintainers for the few other places using it.