From: Christoph Hellwig <hch@infradead.org>
To: Pavel Raiskup <praiskup@redhat.com>
Cc: bug-tar@gnu.org,
"Andrew J. Schorr" <aschorr@telemetry-investments.com>,
Paul Eggert <eggert@cs.ucla.edu>,
linux-fsdevel@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>
Subject: Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks
Date: Tue, 29 Oct 2013 10:12:05 -0700 [thread overview]
Message-ID: <20131029171205.GA13310@infradead.org> (raw)
In-Reply-To: <6917534.P50uorHOUu@nb.usersys.redhat.com>
On Tue, Oct 29, 2013 at 04:27:02PM +0100, Pavel Raiskup wrote:
> CC'ing fs-devel: The question is whether that ^^^^ is not a bug in
> filesystem ??? whether filesystem should not _always_ return to fstat()
> block count at least 1 if there are at least some data (even if these data
> are inlined in inode)? Just for catching the context, this thread starts
> here: http://lists.gnu.org/archive/html/bug-tar/2013-10/msg00030.html
>
> If that is not a bug in fs, is there possible to detect that particular
> file is completely sparse?
For XFS we only support inline data for non-regular files at the moment,
but for example an inode that has data stored just inline will report
zero block, and the unfinished patches to support inline regular file
data would logically do the same.
As already pointed out by Joerg we do have a proper lseek interface to
detect if there are holes.
next prev parent reply other threads:[~2013-10-29 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131028211739.GA26741@ti119.telemetry-investments.com>
[not found] ` <526F376E.5030307@cs.ucla.edu>
[not found] ` <10978717.9ApR7zKiv0@nb.usersys.redhat.com>
2013-10-29 15:27 ` [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks Pavel Raiskup
2013-10-29 15:32 ` Joerg Schilling
2013-10-29 17:12 ` Christoph Hellwig [this message]
2013-10-29 17:37 ` [Bug-tar] " Jan Kara
2013-10-29 22:01 ` Andreas Dilger
2013-10-31 12:11 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029171205.GA13310@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=aschorr@telemetry-investments.com \
--cc=bug-tar@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=praiskup@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).