From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH 1/9] block: Convert various code to bio_for_each_segment() Date: Thu, 7 Nov 2013 12:21:21 -0800 Message-ID: <20131107202121.GF3842@kmo> References: <1383608187-27368-1-git-send-email-kmo@daterainc.com> <1383608187-27368-2-git-send-email-kmo@daterainc.com> <20131107112630.GA31798@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, axboe@kernel.dk, hch@infradead.org, Alexander Viro , Chris Mason , Jaegeuk Kim , Joern Engel , Prasad Joshi , Trond Myklebust To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20131107112630.GA31798@quack.suse.cz> Sender: linux-btrfs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Nov 07, 2013 at 12:26:30PM +0100, Jan Kara wrote: > On Mon 04-11-13 15:36:19, Kent Overstreet wrote: > > With immutable biovecs we don't want code accessing bi_io_vec directly - > > the uses this patch changes weren't incorrect since they all own the > > bio, but it makes the code harder to audit for no good reason - also, > > this will help with multipage bvecs later. > I think you've missed the code in fs/ext4/page-io.c in the conversion > (likely because it was added relatively recently). Thanks!