From: Vasily Kulikov <segoon@openwall.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org,
Stanislav Kinsbursky <skinsbursky@parallels.com>,
bfields@fieldses.org, bharrosh@panasas.com, devel@openvz.org,
oleg@redhat.com
Subject: Re: [Devel] call_usermodehelper in containers
Date: Mon, 11 Nov 2013 16:43:21 +0400 [thread overview]
Message-ID: <20131111124321.GA18028@cachalot> (raw)
In-Reply-To: <20131111071825.62da01d1@tlielax.poochiereds.net>
Hi Jeff,
On Mon, Nov 11, 2013 at 07:18 -0500, Jeff Layton wrote:
> What's the correct approach to fix this? One possibility would be to
> keep a kernel thread around that sits in the correct namespace(s) and
> has the right privileges, and then use that to launch UMH programs.
> That thread could be spawned whenever someone runs rpc.nfsd inside a
> container.
>
> Not very elegant, but it seems like something that would work.
>
> Are there better approaches?
What's the reasoning behind this? I mean, it is not very obvious what
we should keep here. Compare 2 cases:
1) root process with all caps spawns new ns, then drops some of caps;
2) root process with all caps drops some of his caps and then spawns new ns.
>From the programmer's POV both cases are valid and lead to absolutely
the same limitations inside of the new namespace. However, from kernel
POV they differ -- if save cap set when ns is created then in (1) we'll
have cap'ed UMH, in (2) we'll have UMH with only several caps. It might
significantly influence on ability of UMH to do its job and ability of
this limited ns to escape from the sandbox.
So, what semantic should UMH privileges have?
Also, an orthogonal addition: you might want to keep only minimum
information about capabilities or something -- keep only cap_t field in
namespace structure without explicit kernel thread for each ns. When UMH is
created, just fill the required caps in it.
Thanks,
--
Vasily Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2013-11-11 12:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 12:18 call_usermodehelper in containers Jeff Layton
2013-11-11 12:43 ` Vasily Kulikov [this message]
2013-11-11 13:26 ` [Devel] " Jeff Layton
2013-11-12 0:47 ` Greg KH
2013-11-12 11:12 ` Jeff Layton
2013-11-12 13:02 ` Stanislav Kinsbursky
2013-11-12 13:30 ` Jeff Layton
2013-11-15 5:05 ` Eric W. Biederman
2013-11-15 10:40 ` Stanislav Kinsbursky
2013-11-15 11:03 ` Eric W. Biederman
2013-11-15 11:54 ` Stanislav Kinsbursky
2016-02-12 23:39 ` Ian Kent
2016-02-13 16:08 ` Stanislav Kinsburskiy
2016-02-15 0:11 ` Ian Kent
2016-02-18 3:17 ` Eric W. Biederman
2013-11-18 17:28 ` Oleg Nesterov
2013-11-18 18:02 ` Oleg Nesterov
2013-11-19 14:51 ` Jeff Layton
2016-02-11 0:17 ` Ian Kent
2016-02-18 2:57 ` Eric W. Biederman
2016-02-18 3:43 ` Kamezawa Hiroyuki
2016-02-18 6:36 ` Ian Kent
2016-02-18 7:37 ` Ian Kent
2016-02-18 20:45 ` Eric W. Biederman
2016-02-19 3:08 ` Kamezawa Hiroyuki
2016-02-19 5:37 ` Ian Kent
2016-02-19 9:30 ` Kamezawa Hiroyuki
2016-02-20 3:28 ` Ian Kent
2016-02-19 5:14 ` Ian Kent
2016-02-23 2:55 ` Ian Kent
2016-02-23 14:36 ` J. Bruce Fields
2016-02-24 0:55 ` Ian Kent
2016-03-24 7:45 ` Ian Kent
2016-03-25 1:28 ` Oleg Nesterov
2016-03-25 7:25 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111124321.GA18028@cachalot \
--to=segoon@openwall.com \
--cc=bfields@fieldses.org \
--cc=bharrosh@panasas.com \
--cc=devel@openvz.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=skinsbursky@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).