From mboxrd@z Thu Jan  1 00:00:00 1970
From: "J. Bruce Fields" <bfields@redhat.com>
Subject: Re: [patch] locks: missing unlock on error in generic_add_lease()
Date: Wed, 13 Nov 2013 08:51:04 -0500
Message-ID: <20131113135103.GA27536@pad.fieldses.org>
References: <20131113075627.GJ25541@elgon.mountain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Matthew Wilcox <matthew@wil.cx>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Return-path: <kernel-janitors-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20131113075627.GJ25541@elgon.mountain>
Sender: kernel-janitors-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Nov 13, 2013 at 10:56:27AM +0300, Dan Carpenter wrote:
> We should unlock here before returning.

A buggy-caller case, so shouldn't be a huge deal, but obviously should
be fixed, thanks!

	Acked-by: J. Bruce Fields <bfields@redhat.com>

I'm assuming Al will pick it up.

(Though error = -EAGAIN and "goto out" would be more consistent with
other exits.)

--b.

> 
> Fixes: df4e8d2c1d2b ('locks: implement delegations')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static checker stuff.
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index f99d52b..92a0f0a 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -1494,6 +1494,7 @@ static int generic_add_lease(struct file *filp, long arg, struct file_lock **flp
>  
>  	if (is_deleg && arg == F_WRLCK) {
>  		/* Write delegations are not currently supported: */
> +		mutex_unlock(&inode->i_mutex);
>  		WARN_ON_ONCE(1);
>  		return -EINVAL;
>  	}