From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff King <peff@peff.net>
Cc: linux-fsdevel@vger.kernel.org, Waiman Long <Waiman.Long@hp.com>
Subject: Re: [BUG] 3.12 vfs weirdness under load
Date: Wed, 13 Nov 2013 21:40:53 +0000 [thread overview]
Message-ID: <20131113214053.GF13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20131113213605.GA7043@sigill.intra.peff.net>
On Wed, Nov 13, 2013 at 04:36:06PM -0500, Jeff King wrote:
> On Wed, Nov 13, 2013 at 01:05:58AM -0500, Jeff King wrote:
>
> > On v3.12, running "make -j16 test" on a git.git checkout produces random
> > failures in the test suite, whereas it works fine on v3.11.
> > [...]
> > Reading the patch for 232d2d6, it seems plausible that it's a locking
> > problem in the new code, but I don't see anything obviously wrong. I'd
> > expect others can reproduce by running git's test suite, but if not, I'm
> > happy to test patches.
>
> A word of warning to anyone who wants to reproduce this: I believe it
> caused some data loss during my bisect. Git's test suite does a lot of:
>
> mkdir trash.XXXXX
> ... do some tests in trash.XXXXX
> rm -rf trash.XXXXX
>
> >From reading the patch, I'm guessing the bug is causing wrong dir
> entries to be returned under load. Random bits of my home directory are
> missing this morning after my testing; my theory is that when we are
> unlucky enough to hit the race on the "rm", it can end up deleting
> random things.
Move initialization of dentry/vfsmount/mnt to just before the loop in
prepend_path() and see if that fixes what you are seeing...
next prev parent reply other threads:[~2013-11-13 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 6:05 [BUG] 3.12 vfs weirdness under load Jeff King
2013-11-13 21:36 ` Jeff King
2013-11-13 21:40 ` Al Viro [this message]
2013-11-14 14:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113214053.GF13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Waiman.Long@hp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).