From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
Eric Paris <eparis@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fsnotify: Do not share events between notification groups
Date: Wed, 20 Nov 2013 23:26:50 +0100 [thread overview]
Message-ID: <20131120222650.GG30274@quack.suse.cz> (raw)
In-Reply-To: <20131120134959.c889813d7c0953f1181806a9@linux-foundation.org>
On Wed 20-11-13 13:49:59, Andrew Morton wrote:
> On Thu, 14 Nov 2013 01:41:23 +0100 Jan Kara <jack@suse.cz> wrote:
>
> > 13 files changed, 340 insertions(+), 786 deletions(-)
> > create mode 100644 fs/notify/fanotify/fanotify.h
> >
> > Guys, what do you think? The patch definitely needs more testing but it
> > survives some basic tests. Also it's rather large so I can try to split it
> > a bit but since this is an infrastructure change it's hard to make it in
> > small steps...
>
> It's certainly a large patch, but the description makes it sound good ;)
>
> What have you been using to test it? Do we actually have a decent
> *notify test suite, or does everyone hack up their own, then let it
> rot?
Today, I've submitted a test coverage of fanotify syscalls to LTP :).
inotify syscalls already have a coverage there so I tested them as well. I
didn't really test dnotify or audit (besides compilation) but changes there
were pretty minimal. Testing caught some minor issues so I'll be sending V2
today or tomorrow (I want to try to split the patch a bit).
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-11-20 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 0:41 [PATCH] fsnotify: Do not share events between notification groups Jan Kara
2013-11-20 21:49 ` Andrew Morton
2013-11-20 22:26 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120222650.GG30274@quack.suse.cz \
--to=jack@suse.cz \
--cc=LinoSanfilippo@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).