From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] fsnotify: Do not share events between notification groups Date: Wed, 20 Nov 2013 23:26:50 +0100 Message-ID: <20131120222650.GG30274@quack.suse.cz> References: <1384389683-12612-1-git-send-email-jack@suse.cz> <20131120134959.c889813d7c0953f1181806a9@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Lino Sanfilippo , Eric Paris , Al Viro To: Andrew Morton Return-path: Received: from cantor2.suse.de ([195.135.220.15]:47774 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640Ab3KTW0w (ORCPT ); Wed, 20 Nov 2013 17:26:52 -0500 Content-Disposition: inline In-Reply-To: <20131120134959.c889813d7c0953f1181806a9@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 20-11-13 13:49:59, Andrew Morton wrote: > On Thu, 14 Nov 2013 01:41:23 +0100 Jan Kara wrote: > > > 13 files changed, 340 insertions(+), 786 deletions(-) > > create mode 100644 fs/notify/fanotify/fanotify.h > > > > Guys, what do you think? The patch definitely needs more testing but it > > survives some basic tests. Also it's rather large so I can try to split it > > a bit but since this is an infrastructure change it's hard to make it in > > small steps... > > It's certainly a large patch, but the description makes it sound good ;) > > What have you been using to test it? Do we actually have a decent > *notify test suite, or does everyone hack up their own, then let it > rot? Today, I've submitted a test coverage of fanotify syscalls to LTP :). inotify syscalls already have a coverage there so I tested them as well. I didn't really test dnotify or audit (besides compilation) but changes there were pretty minimal. Testing caught some minor issues so I'll be sending V2 today or tomorrow (I want to try to split the patch a bit). Honza -- Jan Kara SUSE Labs, CR