From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kmo@daterainc.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
axboe@kernel.dk, Neil Brown <neilb@suse.de>,
Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com
Subject: Re: [PATCH 1/5] block: Make generic_make_request handle arbitrary sized bios
Date: Mon, 25 Nov 2013 22:09:21 -0800 [thread overview]
Message-ID: <20131126060921.GB6434@infradead.org> (raw)
In-Reply-To: <1385418633-9753-2-git-send-email-kmo@daterainc.com>
> + q->bio_split = bioset_create(4, 0);
> + if (!q->bio_split)
> + goto fail_id;
How did we arrive at a mempool size of 4 to make sure we can always make
progress with arbitrarily sized bios? Shouldn't we document the design
decision somewhere?
> +static struct bio *blk_bio_discard_split(struct request_queue *q,
> + struct bio *bio,
> + struct bio_set *bs)
> +{
One fallout of this should be that it would allows us to impement
a range UNMAP/TRIP much more easily, which would help dramatically
with TRIM performance!
next prev parent reply other threads:[~2013-11-26 6:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 22:30 [PATCH] Make generic_make_request() handle arbitrary size bios Kent Overstreet
2013-11-25 22:30 ` [PATCH 1/5] block: Make generic_make_request handle arbitrary sized bios Kent Overstreet
2013-11-26 6:09 ` Christoph Hellwig [this message]
2013-11-26 7:21 ` Kent Overstreet
2013-11-25 22:30 ` [PATCH 2/5] mtip32xx: handle arbitrary size bios Kent Overstreet
2013-11-26 6:10 ` Christoph Hellwig
2013-11-26 7:32 ` Kent Overstreet
2013-11-25 22:30 ` [PATCH 3/5] block: Gut bio_add_page() Kent Overstreet
2013-11-25 22:30 ` [PATCH 4/5] blk-lib.c: generic_make_request() handles large bios now Kent Overstreet
2013-11-27 12:54 ` Christoph Hellwig
2013-11-27 21:34 ` Kent Overstreet
2013-11-25 22:30 ` [PATCH 5/5] bcache: " Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126060921.GB6434@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=kmo@daterainc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).