From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH 2/5] mtip32xx: handle arbitrary size bios Date: Mon, 25 Nov 2013 23:32:41 -0800 Message-ID: <20131126073240.GG9244@kmo-pixel> References: <1385418633-9753-1-git-send-email-kmo@daterainc.com> <1385418633-9753-3-git-send-email-kmo@daterainc.com> <20131126061018.GC6434@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, Asai Thambi S P , Sam Bradshaw To: Christoph Hellwig Return-path: Received: from mail-pb0-f45.google.com ([209.85.160.45]:57178 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553Ab3KZHcL (ORCPT ); Tue, 26 Nov 2013 02:32:11 -0500 Received: by mail-pb0-f45.google.com with SMTP id rp16so7443154pbb.4 for ; Mon, 25 Nov 2013 23:32:11 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131126061018.GC6434@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 25, 2013 at 10:10:18PM -0800, Christoph Hellwig wrote: > On Mon, Nov 25, 2013 at 02:30:30PM -0800, Kent Overstreet wrote: > > We get a measurable performance increase by handling this in the driver when > > we're already looping over the biovec, instead of handling it separately in > > generic_make_request() (or bio_add_page() originally) > > Given that Jens has a patch queue up to convert the driver to blk-mq > adjusting the blk-mq infrastructure to handle this might be a better > plan forward.. I mostly wanted the patch in the series as an example conversion - converting blk-mq is going to take some thought and time to familiarize myself with the code.