From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] fs: fix iversion handling Date: Tue, 3 Dec 2013 10:25:06 +1100 Message-ID: <20131202232506.GG10988@dastard> References: <20131119151707.GA13412@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Christoph Hellwig Return-path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:59797 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753748Ab3LBXZJ (ORCPT ); Mon, 2 Dec 2013 18:25:09 -0500 Content-Disposition: inline In-Reply-To: <20131119151707.GA13412@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote: > Currently notify_change directly updates i_version for size updates, > which not only is counter to how all other fields are updated through > struct iattr, but also breaks XFS, which need inode updates to happen > under its own lock, and synchronized to the structure that gets written > to the log. > > Remove the update in the common code, and it to btrfs and ext4, > XFS already does a proper updaste internally and currently gets a > double update with the existing code. > > IMHO this is 3.13 and -stable material and should go in through the XFS > tree. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com