From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH] fs: fix iversion handling Date: Tue, 3 Dec 2013 15:54:33 -0500 Message-ID: <20131203205433.GB2648@fieldses.org> References: <20131119151707.GA13412@infradead.org> <20131202173636.GA17724@infradead.org> <529DA5C6.7040403@panasas.com> <20131203094507.GD4906@infradead.org> <529DB536.7050008@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, NFS list To: Boaz Harrosh Return-path: Content-Disposition: inline In-Reply-To: <529DB536.7050008-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Dec 03, 2013 at 12:40:54PM +0200, Boaz Harrosh wrote: > On 12/03/2013 11:45 AM, Christoph Hellwig wrote: > > On Tue, Dec 03, 2013 at 11:35:02AM +0200, Boaz Harrosh wrote: > >> Hi Christoph > >> > >> What happens with all other filesystems exported under KNFSD? > >> > >> As I understand inode_inc_iversion() is used in NFSv4 and up, > >> what will increment the inode-version on changed attributes > >> for them? > > > > It's used by the filesystem for the change attribute that NFSDd > > can optionally use. Most filesystsems don't support it and work > > okay enough when NFS exported. No other filesystem will need > > to adopt for this patch specificly, given that no other filesystem > > uses this infrastructure. > > > > OK Thanks, I did not know that. I assumed change-attribute is > naturally supported. > > I will look at ext4 example and wire up exofs. Because it is very > important for me to support the change-attribute properly. Just please don't follow ext4's example of making support dependent on a mount option. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html