From: Chris Mason <clm@fb.com>
To: Ben Myers <bpm@sgi.com>, Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] fs: fix iversion handling
Date: Wed, 4 Dec 2013 17:01:44 -0500 [thread overview]
Message-ID: <20131204220144.1501.13481@ret> (raw)
In-Reply-To: <20131204212504.GX1935@sgi.com>
Quoting Ben Myers (2013-12-04 16:25:04)
> Hey Christoph,
>
> On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote:
> > Currently notify_change directly updates i_version for size updates,
> > which not only is counter to how all other fields are updated through
> > struct iattr, but also breaks XFS, which need inode updates to happen
> > under its own lock, and synchronized to the structure that gets written
> > to the log.
> >
> > Remove the update in the common code, and it to btrfs and ext4,
> > XFS already does a proper updaste internally and currently gets a
> > double update with the existing code.
> >
> > IMHO this is 3.13 and -stable material and should go in through the XFS
> > tree.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Does this still need a btrfs ack, or is it ready to go?
The btrfs parts look good to me.
Signed-off-by: Chris Mason <clm@fb.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-04 22:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 15:17 [PATCH] fs: fix iversion handling Christoph Hellwig
2013-12-02 17:36 ` Christoph Hellwig
2013-12-02 22:05 ` Andreas Dilger
2013-12-03 9:39 ` Christoph Hellwig
2013-12-02 22:11 ` Jan Kara
[not found] ` <20131202173636.GA17724-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-12-03 9:35 ` Boaz Harrosh
2013-12-03 9:45 ` Christoph Hellwig
[not found] ` <20131203094507.GD4906-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-12-03 10:40 ` Boaz Harrosh
[not found] ` <529DB536.7050008-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2013-12-03 20:54 ` J. Bruce Fields
2013-12-02 23:25 ` Dave Chinner
2013-12-04 21:25 ` Ben Myers
2013-12-04 22:01 ` Chris Mason [this message]
2013-12-05 22:37 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204220144.1501.13481@ret \
--to=clm@fb.com \
--cc=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).