From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH] fs: fix iversion handling Date: Wed, 4 Dec 2013 17:01:44 -0500 Message-ID: <20131204220144.1501.13481@ret> References: <20131119151707.GA13412@infradead.org> <20131204212504.GX1935@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Ben Myers , Christoph Hellwig Return-path: In-Reply-To: <20131204212504.GX1935@sgi.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-fsdevel.vger.kernel.org Quoting Ben Myers (2013-12-04 16:25:04) > Hey Christoph, > > On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote: > > Currently notify_change directly updates i_version for size updates, > > which not only is counter to how all other fields are updated through > > struct iattr, but also breaks XFS, which need inode updates to happen > > under its own lock, and synchronized to the structure that gets written > > to the log. > > > > Remove the update in the common code, and it to btrfs and ext4, > > XFS already does a proper updaste internally and currently gets a > > double update with the existing code. > > > > IMHO this is 3.13 and -stable material and should go in through the XFS > > tree. > > > > Signed-off-by: Christoph Hellwig > > Does this still need a btrfs ack, or is it ready to go? The btrfs parts look good to me. Signed-off-by: Chris Mason _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs