From: Christoph Hellwig <hch@infradead.org>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
viro@zeniv.linux.org.uk, xfs@oss.sgi.com,
reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure
Date: Fri, 6 Dec 2013 11:47:20 -0800 [thread overview]
Message-ID: <20131206194720.GB32122@infradead.org> (raw)
In-Reply-To: <1386159157.2711.11.camel@menhir>
On Wed, Dec 04, 2013 at 12:12:37PM +0000, Steven Whitehouse wrote:
> > error = posix_acl_equiv_mode(acl, &mode);
> > + if (error < 0)
> >
> Andy Price has pointed out a missing "return error;" here
>
> > - if (error <= 0) {
> > - posix_acl_release(acl);
> > + if (error == 0)
> > acl = NULL;
> >
> > - if (error < 0)
> > - return error;
> > - }
> > -
>
> Also, there seems to be a white space error in the xfs patch around line
> 170 in fs/xfs/xfs_iops.c where there is an added "if (default_acl)" with
> a space before the tab,
I'll take care of these for the next version.
next prev parent reply other threads:[~2013-12-06 19:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 11:59 [PATCH 00/18] Consolidate Posix ACL implementation Christoph Hellwig
2013-12-01 11:59 ` [PATCH 01/18] reiserfs: prefix ACL symbols with reiserfs_ Christoph Hellwig
2013-12-02 20:15 ` Jan Kara
2013-12-01 11:59 ` [PATCH 02/18] fs: add get_acl helper Christoph Hellwig
2013-12-02 20:14 ` Jan Kara
2013-12-01 11:59 ` [PATCH 03/18] fs: add a set_acl inode operation Christoph Hellwig
2013-12-02 20:57 ` Jan Kara
2013-12-01 11:59 ` [PATCH 04/18] fs: add generic xattr_acl handlers Christoph Hellwig
2013-12-02 20:59 ` Jan Kara
2013-12-01 11:59 ` [PATCH 05/18] fs: make posix_acl_chmod more useful Christoph Hellwig
2013-12-02 21:09 ` Jan Kara
2013-12-01 11:59 ` [PATCH 06/18] fs: make posix_acl_create " Christoph Hellwig
2013-12-02 21:11 ` Jan Kara
2013-12-01 11:59 ` [PATCH 07/18] btrfs: use generic posix ACL infrastructure Christoph Hellwig
2013-12-01 11:59 ` [PATCH 08/18] ext2/3/4: " Christoph Hellwig
2013-12-02 22:13 ` Jan Kara
2013-12-02 22:18 ` [Jfs-discussion] " gary sheppard
2013-12-01 11:59 ` [PATCH 09/18] f2fs: " Christoph Hellwig
2013-12-06 1:37 ` Jaegeuk Kim
2013-12-08 9:14 ` Christoph Hellwig
2013-12-08 23:28 ` Jaegeuk Kim
2013-12-01 11:59 ` [PATCH 10/18] hfsplus: " Christoph Hellwig
2013-12-01 14:36 ` Vyacheslav Dubeyko
2013-12-01 11:59 ` [PATCH 11/18] jffs2: " Christoph Hellwig
2013-12-01 11:59 ` [PATCH 12/18] ocfs2: " Christoph Hellwig
2013-12-02 23:00 ` Jan Kara
2013-12-03 10:48 ` Christoph Hellwig
2013-12-01 11:59 ` [PATCH 13/18] reiserfs: " Christoph Hellwig
2013-12-02 22:17 ` Jan Kara
2013-12-01 11:59 ` [PATCH 14/18] xfs: " Christoph Hellwig
2013-12-02 23:34 ` Dave Chinner
2013-12-01 11:59 ` [PATCH 15/18] jfs: " Christoph Hellwig
2013-12-02 22:11 ` [Jfs-discussion] " Dave Kleikamp
2013-12-01 11:59 ` [PATCH 16/18] gfs2: " Christoph Hellwig
2013-12-04 12:12 ` [Cluster-devel] " Steven Whitehouse
2013-12-06 19:47 ` Christoph Hellwig [this message]
2013-12-01 11:59 ` [PATCH 17/18] nfs: use generic posix ACL infrastructure for v3 Posix ACLs Christoph Hellwig
2013-12-01 11:59 ` [PATCH 18/18] fs: remove generic_acl Christoph Hellwig
2013-12-05 17:57 ` [PATCH 00/18] Consolidate Posix ACL implementation Andreas Gruenbacher
2013-12-06 19:46 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2013-12-11 10:42 [PATCH 00/18] Consolidate Posix ACL implementation V2 Christoph Hellwig
2013-12-11 10:42 ` [PATCH 16/18] gfs2: use generic posix ACL infrastructure Christoph Hellwig
2013-12-11 10:52 ` [Cluster-devel] " Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206194720.GB32122@infradead.org \
--to=hch@infradead.org \
--cc=cluster-devel@redhat.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).