From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kmo@daterainc.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hch@infradead.org, clm@fb.com,
viro@zeniv.linux.org.uk, zab@redhat.com, shaggy@kernel.org
Subject: Re: [PATCH 10/11] block: Add bio_get_user_pages()
Date: Fri, 6 Dec 2013 11:57:19 -0800 [thread overview]
Message-ID: <20131206195719.GA9872@infradead.org> (raw)
In-Reply-To: <1386108017-27964-11-git-send-email-kmo@daterainc.com>
On Tue, Dec 03, 2013 at 02:00:16PM -0800, Kent Overstreet wrote:
> This replaces some of the code that was in __bio_map_user_iov(), and
> soon we're going to use this helper in the dio code.
>
> Note that this relies on the recent change to make
> generic_make_request() take arbitrary sized bios - we're not using
> bio_add_page() here.
__bio_map_user_iov was using bio_add_pc_page anyway. I might
misremember some of the earlier patches, but how do you do arbitrary
splitting of BLOCK_PC bios? Given that they come with a SCSI CDB
attached I can't see how we could split them at all.
Also when you factor code out and change behaviour please always
try to do that in two separate patches so that it's easier reviewable.
next prev parent reply other threads:[~2013-12-06 19:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 22:00 [PATCH] DIO rewrite Kent Overstreet
2013-12-03 22:00 ` [PATCH 01/11] block: Make generic_make_request handle arbitrary sized bios Kent Overstreet
2013-12-03 22:00 ` [PATCH 02/11] block: Gut bio_add_page() Kent Overstreet
2013-12-03 22:00 ` [PATCH 03/11] btrfs: generic_make_request() handles arbitrary size bios now Kent Overstreet
2013-12-03 22:00 ` [PATCH 04/11] btrfs: convert to bio_for_each_segment() Kent Overstreet
2013-12-03 22:00 ` [PATCH 05/11] iov_iter: Move iov_iter to uio.h Kent Overstreet
2013-12-06 11:09 ` Christoph Hellwig
2013-12-03 22:00 ` [PATCH 06/11] iov_iter: Kill iov_iter_single_seg_count() Kent Overstreet
2013-12-06 11:11 ` Christoph Hellwig
2013-12-03 22:00 ` [PATCH 07/11] iov_iter: Kill written arg to iov_iter_init() Kent Overstreet
2013-12-06 11:14 ` Christoph Hellwig
2013-12-03 22:00 ` [PATCH 08/11] block: convert to iov_iter Kent Overstreet
2013-12-06 19:50 ` Christoph Hellwig
2013-12-03 22:00 ` [PATCH 09/11] block: iov_count_pages() Kent Overstreet
2013-12-06 19:53 ` Christoph Hellwig
2013-12-03 22:00 ` [PATCH 10/11] block: Add bio_get_user_pages() Kent Overstreet
2013-12-06 19:57 ` Christoph Hellwig [this message]
2013-12-03 22:00 ` [PATCH 11/11] direct-io: Rewrite based on immutable biovecs Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206195719.GA9872@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=kmo@daterainc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).