From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: viro@zeniv.linux.org.uk, keescook@chromium.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH -next 0/3] seq_printf/puts/putc: Start to convert to return void
Date: Wed, 11 Dec 2013 00:20:40 -0500 (EST) [thread overview]
Message-ID: <20131211.002040.1061939246483044835.davem@davemloft.net> (raw)
In-Reply-To: <cover.1386738050.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 10 Dec 2013 21:12:41 -0800
> Many uses of the return value of seq_printf/seq_puts/seq_putc are
> incorrect. Many assume that the return value is the number of
> chars emitted into a buffer like printf/puts/putc.
>
> It would be better to make the return value of these functions void
> to avoid these misuses.
>
> Start to do so.
> Convert seq_overflow to a public function from a static function.
>
> Remove the return uses of seq_printf/seq_puts/seq_putc from net.
> Add a seq_overflow function call instead.
I'm fine with this going in whatever tree is appropriate for
the seq_overflow un-static change:
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2013-12-11 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 5:12 [PATCH -next 0/3] seq_printf/puts/putc: Start to convert to return void Joe Perches
2013-12-11 5:12 ` [PATCH -next 1/3] seq: Add a seq_overflow test Joe Perches
2013-12-11 23:27 ` Ryan Mallon
2013-12-11 23:31 ` Joe Perches
2013-12-11 5:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211.002040.1061939246483044835.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=coreteam@netfilter.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).