From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
Eric Paris <eparis@parisplace.org>
Subject: Re: [PATCH 1/3] inotify: Provide function for name length rounding
Date: Wed, 11 Dec 2013 03:22:00 -0800 [thread overview]
Message-ID: <20131211112200.GA1915@infradead.org> (raw)
In-Reply-To: <1385077019-21544-2-git-send-email-jack@suse.cz>
On Fri, Nov 22, 2013 at 12:36:57AM +0100, Jan Kara wrote:
> Rounding of name length when passing it to userspace was done in several
> places. Provide a function to do it and use it in all places.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
BTw, I hadn't noticed kernel.h has a roundup() in addition to
round_up(). And XFS also has roundup64 which isn't needed as far as I
can see.. None of them are documented in the slightest way either,
ugh..
next prev parent reply other threads:[~2013-12-11 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 23:36 [PATCH 0/3 v2] fsnotify: Do not share events between notification groups Jan Kara
2013-11-21 23:36 ` [PATCH 1/3] inotify: Provide function for name length rounding Jan Kara
2013-12-11 10:54 ` Jan Kara
2013-12-11 11:22 ` Christoph Hellwig [this message]
2013-12-11 15:42 ` Jan Kara
2013-11-21 23:36 ` [PATCH 2/3] fsnotify: Do not share events between notification groups Jan Kara
2013-12-11 11:27 ` Christoph Hellwig
2013-12-11 15:49 ` Jan Kara
2013-11-21 23:36 ` [PATCH 3/3] fsnotify: Remove .should_send_event callback Jan Kara
2013-12-11 11:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211112200.GA1915@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=eparis@parisplace.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).