From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/3] fsnotify: Do not share events between notification
 groups
Date: Wed, 11 Dec 2013 03:27:55 -0800
Message-ID: <20131211112755.GB1915@infradead.org>
References: <1385077019-21544-1-git-send-email-jack@suse.cz>
 <1385077019-21544-3-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
	Eric Paris <eparis@parisplace.org>
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.9]:43748 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750864Ab3LKL14 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 11 Dec 2013 06:27:56 -0500
Content-Disposition: inline
In-Reply-To: <1385077019-21544-3-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

>  static int dnotify_handle_event(struct fsnotify_group *group,
> +				struct inode *to_tell,

Can we just call this variable inode? :)

> @@ -155,7 +154,7 @@ static struct fsnotify_ops dnotify_fsnotify_ops = {
>  	.should_send_event = dnotify_should_send_event,
>  	.free_group_priv = NULL,
>  	.freeing_mark = NULL,
> -	.free_event_priv = NULL,
> +	.free_event = NULL,
>  };

Please also drop all thee pointless NULL method initializations.

> +struct fsnotify_event {
> +	struct list_head list;
> +	/* to_tell may ONLY be dereferenced during handle_event(). */
> +	struct inode *to_tell;	/* either the inode the event happened to or its parent */

Again, I'd just call this member inode.

Looks good except for the minor nitpicks,

Reviewed-by: Christoph Hellwig <hch@lst.de>