From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 1/3] inotify: Provide function for name length rounding Date: Wed, 11 Dec 2013 16:42:23 +0100 Message-ID: <20131211154223.GB1163@quack.suse.cz> References: <1385077019-21544-1-git-send-email-jack@suse.cz> <1385077019-21544-2-git-send-email-jack@suse.cz> <20131211112200.GA1915@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Andrew Morton , linux-fsdevel@vger.kernel.org, Al Viro , Eric Paris To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:57665 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245Ab3LKPm0 (ORCPT ); Wed, 11 Dec 2013 10:42:26 -0500 Content-Disposition: inline In-Reply-To: <20131211112200.GA1915@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 11-12-13 03:22:00, Christoph Hellwig wrote: > On Fri, Nov 22, 2013 at 12:36:57AM +0100, Jan Kara wrote: > > Rounding of name length when passing it to userspace was done in several > > places. Provide a function to do it and use it in all places. > > > > Signed-off-by: Jan Kara > > Looks good, > > Reviewed-by: Christoph Hellwig Thanks! > BTw, I hadn't noticed kernel.h has a roundup() in addition to > round_up(). And XFS also has roundup64 which isn't needed as far as I > can see.. None of them are documented in the slightest way either, > ugh.. Yeah... There should be a note somewhere that round_up() works only for y being a power of 2. Honza -- Jan Kara SUSE Labs, CR