From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
Eric Paris <eparis@parisplace.org>
Subject: Re: [PATCH 2/3] fsnotify: Do not share events between notification groups
Date: Wed, 11 Dec 2013 16:49:56 +0100 [thread overview]
Message-ID: <20131211154956.GC1163@quack.suse.cz> (raw)
In-Reply-To: <20131211112755.GB1915@infradead.org>
On Wed 11-12-13 03:27:55, Christoph Hellwig wrote:
> > static int dnotify_handle_event(struct fsnotify_group *group,
> > + struct inode *to_tell,
>
> Can we just call this variable inode? :)
OK, done.
> > @@ -155,7 +154,7 @@ static struct fsnotify_ops dnotify_fsnotify_ops = {
> > .should_send_event = dnotify_should_send_event,
> > .free_group_priv = NULL,
> > .freeing_mark = NULL,
> > - .free_event_priv = NULL,
> > + .free_event = NULL,
> > };
>
> Please also drop all thee pointless NULL method initializations.
OK, I did this for all notification users as a separate patch.
> > +struct fsnotify_event {
> > + struct list_head list;
> > + /* to_tell may ONLY be dereferenced during handle_event(). */
> > + struct inode *to_tell; /* either the inode the event happened to or its parent */
>
> Again, I'd just call this member inode.
>
> Looks good except for the minor nitpicks,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-12-11 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 23:36 [PATCH 0/3 v2] fsnotify: Do not share events between notification groups Jan Kara
2013-11-21 23:36 ` [PATCH 1/3] inotify: Provide function for name length rounding Jan Kara
2013-12-11 10:54 ` Jan Kara
2013-12-11 11:22 ` Christoph Hellwig
2013-12-11 15:42 ` Jan Kara
2013-11-21 23:36 ` [PATCH 2/3] fsnotify: Do not share events between notification groups Jan Kara
2013-12-11 11:27 ` Christoph Hellwig
2013-12-11 15:49 ` Jan Kara [this message]
2013-11-21 23:36 ` [PATCH 3/3] fsnotify: Remove .should_send_event callback Jan Kara
2013-12-11 11:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211154956.GC1163@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=eparis@parisplace.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).