From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 2/3] fsnotify: Do not share events between notification groups Date: Wed, 11 Dec 2013 16:49:56 +0100 Message-ID: <20131211154956.GC1163@quack.suse.cz> References: <1385077019-21544-1-git-send-email-jack@suse.cz> <1385077019-21544-3-git-send-email-jack@suse.cz> <20131211112755.GB1915@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Andrew Morton , linux-fsdevel@vger.kernel.org, Al Viro , Eric Paris To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:57913 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904Ab3LKPt5 (ORCPT ); Wed, 11 Dec 2013 10:49:57 -0500 Content-Disposition: inline In-Reply-To: <20131211112755.GB1915@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 11-12-13 03:27:55, Christoph Hellwig wrote: > > static int dnotify_handle_event(struct fsnotify_group *group, > > + struct inode *to_tell, > > Can we just call this variable inode? :) OK, done. > > @@ -155,7 +154,7 @@ static struct fsnotify_ops dnotify_fsnotify_ops = { > > .should_send_event = dnotify_should_send_event, > > .free_group_priv = NULL, > > .freeing_mark = NULL, > > - .free_event_priv = NULL, > > + .free_event = NULL, > > }; > > Please also drop all thee pointless NULL method initializations. OK, I did this for all notification users as a separate patch. > > +struct fsnotify_event { > > + struct list_head list; > > + /* to_tell may ONLY be dereferenced during handle_event(). */ > > + struct inode *to_tell; /* either the inode the event happened to or its parent */ > > Again, I'd just call this member inode. > > Looks good except for the minor nitpicks, > > Reviewed-by: Christoph Hellwig Honza -- Jan Kara SUSE Labs, CR