From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: sougata@tuxera.com, hch@infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Szabolcs Szakacsits <szaka@tuxera.com>
Subject: Re: [PATCH] hfsplus: Remove hfsplus_file_lookup
Date: Wed, 11 Dec 2013 19:11:53 +0000 [thread overview]
Message-ID: <20131211191153.GZ10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AE333CDA-DD74-42B8-92F4-551ACCAD8AFA@dubeyko.com>
On Wed, Dec 11, 2013 at 10:49:29PM +0300, Vyacheslav Dubeyko wrote:
> This feature worked earlier under Linux. So, I suppose that some changes in HFS+ driver
> or in VFS broke it. And it needs to investigate and fix the reported issue. Thank you for the
> report.
This "feature" is severely broken and yes, outright removal is what I'd
suggest for a fix. HFS+ allows hardlinks to files, which means that
you allow multiple dentries for the same inode with ->lookup() in it,
which is asking for deadlocks.
This is fundamentally not supported. Considering that forks are lousy
idea in the first place, I'd seriously suggest to remove that idiocy for
good.
next prev parent reply other threads:[~2013-12-11 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 16:56 [PATCH] hfsplus: Remove hfsplus_file_lookup Sougata Santra
2013-12-11 19:49 ` Vyacheslav Dubeyko
2013-12-11 19:11 ` Al Viro [this message]
2013-12-11 21:08 ` Anton Altaparmakov
2013-12-12 6:35 ` Vyacheslav Dubeyko
2013-12-12 8:18 ` Christoph Hellwig
2013-12-12 8:16 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2013-12-12 17:02 Sougata Santra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211191153.GZ10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=sougata@tuxera.com \
--cc=szaka@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).