From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Potentially unbounded allocations in seq_read?
Date: Thu, 12 Dec 2013 14:21:58 +0000 [thread overview]
Message-ID: <20131212142157.GD10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1386856771.6066.77.camel@tursulin-linux.isw.intel.com>
On Thu, Dec 12, 2013 at 01:59:31PM +0000, Tvrtko Ursulin wrote:
> > a) *what* errors other than -ENAMETOOLONG?
>
> Is this your way of saying there can't be any other errors from d_path?
Check yourself... It is the only error that makes sense there and yes,
it is the only one being returned.
> > b) d_path() not fitting into 2Mb is definitely a bug. If you really have
> > managed to get a dentry tree 1 million levels deep, you have much worse
> > problems.
> > c) which kernel version it is?
>
> 3.10. I can't imagine this is an actual dentry tree somewhere, probably
> just a bug of some sort. I'll probably hunt it down completely some time
> next week, time permitting.
Sounds like missing backport of 118b23 ("cope with potentially long ->d_dname()
output for shmem/hugetlb"). It *is* in -stable (linux-3.10.y has it since
3.10.17 as commit ad4c3c), but if your tree doesn't have it, that's the one
to try first...
next prev parent reply other threads:[~2013-12-12 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 17:04 Potentially unbounded allocations in seq_read? Tvrtko Ursulin
2013-12-11 17:48 ` Tvrtko Ursulin
2013-12-11 18:00 ` Al Viro
2013-12-11 17:49 ` Al Viro
2013-12-11 17:59 ` Tvrtko Ursulin
2013-12-11 18:07 ` Al Viro
2013-12-12 13:40 ` Tvrtko Ursulin
2013-12-12 13:49 ` Al Viro
2013-12-12 13:59 ` Tvrtko Ursulin
2013-12-12 14:21 ` Al Viro [this message]
2013-12-12 14:52 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212142157.GD10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).