From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Eric Paris <eparis@parisplace.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/4] fsnotify: Remove pointless NULL initializers
Date: Fri, 13 Dec 2013 04:08:05 -0800 [thread overview]
Message-ID: <20131213120805.GB8495@infradead.org> (raw)
In-Reply-To: <1386777217-29988-5-git-send-email-jack@suse.cz>
On Wed, Dec 11, 2013 at 04:53:37PM +0100, Jan Kara wrote:
> We usually rely on the fact that struct members not specified in the
> initializer are set to NULL. So do that with fsnotify function pointers
> as well.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2013-12-13 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 15:53 [PATCH 0/4 v3] fsnotify: Do not share events between notification groups Jan Kara
2013-12-11 15:53 ` [PATCH 1/4] inotify: Provide function for name length rounding Jan Kara
2013-12-11 15:53 ` [PATCH 2/4] fsnotify: Do not share events between notification groups Jan Kara
2013-12-11 15:53 ` [PATCH 3/4] fsnotify: Remove .should_send_event callback Jan Kara
2013-12-11 15:53 ` [PATCH 4/4] fsnotify: Remove pointless NULL initializers Jan Kara
2013-12-13 12:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213120805.GB8495@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=eparis@parisplace.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).