From: Christoph Hellwig <hch@infradead.org>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Fabian Frederick <fabf@skynet.be>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jeff Mahoney <jeffm@suse.com>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/1] reiserfs:Adding tmpfile support
Date: Thu, 26 Dec 2013 01:02:03 -0800 [thread overview]
Message-ID: <20131226090203.GA17995@infradead.org> (raw)
In-Reply-To: <CAFLxGvx1m_HL7wPA1=LXpjJvwN7oMCKjxJk4AHO+cgQW0FPf+Q@mail.gmail.com>
On Wed, Dec 25, 2013 at 02:39:48PM +0100, Richard Weinberger wrote:
> On Wed, Dec 25, 2013 at 2:23 PM, Fabian Frederick <fabf@skynet.be> wrote:
> > This patch is largely based on reiserfs_create function.
> > -Removing dquot_initialize (cf ext2/tmpfile)
> > -Removing add_entry code.
> > -Adding d_tmpfile generic call.
> >
> > It was not extensively tested; other solutions would
> > be to work with hidden entries or merge
> > creation - tmpfile process.
>
> Is it worth adding new features to a legacy file system like reiserfs?
Having user API parity is always a good thing, especially if it doesn't
require on-disk format changes. Same case as FIEMAP or
SEEK_DATA/SEEK_HOLE to mention some recent features.
That being said this needs to follow them model of ext3/ext3/xfs and
add the inode to the unlink/orphan inode list on tmpfile creation and
move it out on flink.
We'll also need a proper verifier for the expected behaviour, which I
hope we'll get out of the work in progress XFS support.
prev parent reply other threads:[~2013-12-26 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 13:23 [PATCH 1/1] reiserfs:Adding tmpfile support Fabian Frederick
2013-12-25 13:39 ` Richard Weinberger
2013-12-26 9:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226090203.GA17995@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).