From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/1] reiserfs:Adding tmpfile support Date: Thu, 26 Dec 2013 01:02:03 -0800 Message-ID: <20131226090203.GA17995@infradead.org> References: <20131225142340.92120e3c3d9a98858db79748@skynet.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Fabian Frederick , LKML , linux-fsdevel , Andrew Morton , Al Viro , Jeff Mahoney , Jan Kara To: Richard Weinberger Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:44025 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381Ab3LZJCH (ORCPT ); Thu, 26 Dec 2013 04:02:07 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Dec 25, 2013 at 02:39:48PM +0100, Richard Weinberger wrote: > On Wed, Dec 25, 2013 at 2:23 PM, Fabian Frederick wrote: > > This patch is largely based on reiserfs_create function. > > -Removing dquot_initialize (cf ext2/tmpfile) > > -Removing add_entry code. > > -Adding d_tmpfile generic call. > > > > It was not extensively tested; other solutions would > > be to work with hidden entries or merge > > creation - tmpfile process. > > Is it worth adding new features to a legacy file system like reiserfs? Having user API parity is always a good thing, especially if it doesn't require on-disk format changes. Same case as FIEMAP or SEEK_DATA/SEEK_HOLE to mention some recent features. That being said this needs to follow them model of ext3/ext3/xfs and add the inode to the unlink/orphan inode list on tmpfile creation and move it out on flink. We'll also need a proper verifier for the expected behaviour, which I hope we'll get out of the work in progress XFS support.