From: Kent Overstreet <kmo@daterainc.com>
To: Chris Mason <clm@fb.com>
Cc: "muthu.lkml@gmail.com" <muthu.lkml@gmail.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"fengguang.wu@intel.com" <fengguang.wu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkp@linux.intel.com" <lkp@linux.intel.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [block:for-3.14/core] kernel BUG at fs/bio.c:1748
Date: Wed, 8 Jan 2014 13:14:54 -0800 [thread overview]
Message-ID: <20140108211454.GC7291@kmo-pixel> (raw)
In-Reply-To: <1389215536.23310.37.camel@ret.masoncoding.com>
On Wed, Jan 08, 2014 at 09:11:49PM +0000, Chris Mason wrote:
> On Wed, 2014-01-08 at 13:01 -0800, Muthu Kumar wrote:
> > On Wed, Jan 8, 2014 at 12:51 PM, Chris Mason <clm@fb.com> wrote:
> > > On Wed, 2014-01-08 at 12:40 -0800, Muthu Kumar wrote:
> > >> On Wed, Jan 8, 2014 at 12:16 PM, Chris Mason <clm@fb.com> wrote:
> > >> > On Wed, 2014-01-08 at 11:54 -0800, Muthu Kumar wrote:
> > >> >> Chris,
> > >> >>
> > >> >> [ 8.336061] WARNING: CPU: 0 PID: 0 at fs/bio.c:1778 bio_endio+0xbe/0x100()
> > >> >> [ 8.336062] bio_endio: bio for (unknown) without endio
> > >> >>
> > >> >> This is my recent change to avoid memory leak in bio_endio. But I
> > >> >> think the problem is higher up, most likely bio_endio is called twice
> > >> >> on the same bio (which was freed before).
> > >> >>
> > >> >
> > >> > I think these are just two separate problems. Lets ignore the WARN_ON
> > >> > for now.
> > >> >
> > >>
> > >> Not really... the BUG that is triggered:
> > >>
> > >> kernel BUG at fs/bio.c:523!
> > >>
> > >> It is in bio_put() (added to bio_endio() as part of recent change)
> > >> which gets an already freed bio.
> > >>
> > >
> > > Oh! I see. Let me try with that one reverted. Thanks!
> > >
> > > -chris
> > >
> >
> > But, like I said, problem is in different place. I am running a "dd"
> > on ext4 fs for a while now, but didn't hit the problem. Any idea to
> > repro locally? I would also suggest running just the for-3.1/core to
> > isolate the issue.
>
> Just reverting that change fixes it for me. Jens mentioned it was
> broken for on-stack bios.
On-stack bios? I don't recall ever coming across such a thing, who what
where why?
i would expect on stack bios to work though, i'm really curious how it
was broken
next prev parent reply other threads:[~2014-01-08 21:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 5:31 [block:for-3.14/core] kernel BUG at fs/bio.c:1748 fengguang.wu
2014-01-03 19:51 ` Muthu Kumar
2014-01-05 9:46 ` Fengguang Wu
2014-01-05 16:28 ` Muthu Kumar
2014-01-06 2:21 ` Fengguang Wu
2014-01-06 22:10 ` Kent Overstreet
2014-01-07 0:47 ` Muthu Kumar
2014-01-07 2:52 ` Kent Overstreet
2014-01-07 5:53 ` Fengguang Wu
2014-01-07 20:15 ` Muthu Kumar
2014-01-07 20:29 ` Chris Mason
2014-01-07 21:23 ` Muthu Kumar
2014-01-08 19:41 ` Chris Mason
2014-01-08 19:54 ` Muthu Kumar
2014-01-08 20:16 ` Chris Mason
2014-01-08 20:40 ` Muthu Kumar
2014-01-08 20:51 ` Chris Mason
2014-01-08 21:01 ` Muthu Kumar
2014-01-08 21:11 ` Chris Mason
2014-01-08 21:14 ` Kent Overstreet [this message]
2014-01-08 21:18 ` Muthu Kumar
2014-01-08 21:24 ` Kent Overstreet
2014-01-08 21:13 ` Chris Mason
2014-01-08 21:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108211454.GC7291@kmo-pixel \
--to=kmo@daterainc.com \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=fengguang.wu@intel.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@linux.intel.com \
--cc=muthu.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).