From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functionality Date: Thu, 6 Feb 2014 22:23:21 -0800 Message-ID: <20140206222321.278887c0.akpm@linux-foundation.org> References: <1390577118.2287.64.camel@slavad-ubuntu-12.04> <20140205154833.be220231580431b148c370f3@linux-foundation.org> <1391667679.15555.3.camel@ubuntu> <1391753144.15555.44.camel@ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Linux FS devel list , Al Viro , ChristophHellwig , Hin-Tak Leung To: Vyacheslav Dubeyko Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53652 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbaBGGSR (ORCPT ); Fri, 7 Feb 2014 01:18:17 -0500 In-Reply-To: <1391753144.15555.44.camel@ubuntu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 07 Feb 2014 10:05:44 +0400 Vyacheslav Dubeyko wrote: > Hi Andrew, > > On Thu, 2014-02-06 at 10:21 +0400, Vyacheslav Dubeyko wrote: > > On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote: > > > On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko wrote: > > > > > > > This second version of patchset that implements journal replay > > > > functionality in HFS+ file system driver. > > > > > > The series introduces a lot of build glitches on i386 (and other 32-bit > > > builds) > > > > > > - tons of printk mismatch warnings > > > > > > - unresolvable references to __udivdi3 and __umoddi3 (need to use > > > do_div() or similar). > > > > > > - several bisection holes: > > > > > > - with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE' > > > > > > - with three patches applied, warning: 'hfsplus_create_journal' used but never defined > > > > > I've reproduced (1) printk mismatch warnings; and (2) unresolvable > references to __udivdi3 and __umoddi3 build issues. But I am unable to > reproduce the issue with JHDR_SIZE and hfsplus_create_journal. And I > assume that I misunderstand something. This declarations live inside of > journal.c file only. And I add journal.c file in Makefile in > 0015-hfsplus-integrate-journal-replay-support-into-driver.patch only. > So, how do you achieve build issues with JHDR_SIZE and > hfsplus_create_journal? Could you share your way? Maybe do you use some > special compilation options or additional tools during build? Nope, just i386 "make allmodconfig ; make fs/hfsplus/journal.o". Apply these: hfsplus-add-necessary-declarations-for-journal-replay hfsplus-rework-hfsplus_submit_bio-method hfsplus-implement-init-destroy-journal-object-functionality hfsplus-implement-functionality-for-hfsplus_journal_need_init-flag get this: fs/hfsplus/journal.c: In function 'hfsplus_create_journal': fs/hfsplus/journal.c:186: error: implicit declaration of function 'JHDR_SIZE' fs/hfsplus/journal.c: In function 'hfsplus_init_journal': fs/hfsplus/journal.c:244: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'sector_t' fs/hfsplus/journal.c:259: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'sector_t' fs/hfsplus/journal.c:264: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'sector_t' fs/hfsplus/journal.c:282: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'sector_t' fs/hfsplus/journal.c:290: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'sector_t' z:/usr/src/25> grep JHDR_SIZE include/linux/*.h z:/usr/src/25> grep JHDR_SIZE fs/hfsplus/*.[ch] fs/hfsplus/journal.c:#define HFSPLUS_DEFAULT_JHDR_SIZE (4 * 1024) fs/hfsplus/journal.c: jnl->jh->jhdr_size = cpu_to_le32(HFSPLUS_DEFAULT_JHDR_SIZE); fs/hfsplus/journal.c: jnl->jh->start = cpu_to_le64(JHDR_SIZE(jnl->jh)); fs/hfsplus/journal.c: jnl->jh->end = cpu_to_le64(JHDR_SIZE(jnl->jh));