From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] jfs: fix generic posix ACL regression Date: Sat, 8 Feb 2014 08:08:18 +0100 Message-ID: <20140208070818.GA8758@lst.de> References: <52F54928.9050601@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Michael L. Semon" , Christoph Hellwig , JFS Discussion , LKML , "linux-fsdevel@vger.kernel.org" To: Dave Kleikamp Return-path: Content-Disposition: inline In-Reply-To: <52F54928.9050601@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Feb 07, 2014 at 02:59:20PM -0600, Dave Kleikamp wrote: > -#ifdef JFS_POSIX_ACL > +#ifdef CONFIG_JFS_POSIX_ACL Ooops, sorry. I don't understand the can_set_xattr move - while the check obviously aren't needed when using the generic xattr code I don't see how they cause harm either.