From mboxrd@z Thu Jan 1 00:00:00 1970 From: "greg@kroah.com" Subject: Re: RFC: [PATCH] staging/lustre/llite: fix O_TMPFILE/O_LOV_DELAY_CREATE conflict Date: Mon, 10 Feb 2014 16:51:39 -0800 Message-ID: <20140211005139.GA10792@kroah.com> References: <20140210212929.GF18016@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "Drokin, Oleg" , Peng Tao , Al Viro To: "Dilger, Andreas" Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33949 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbaBKAu3 (ORCPT ); Mon, 10 Feb 2014 19:50:29 -0500 Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 6853A2117D for ; Mon, 10 Feb 2014 19:50:25 -0500 (EST) Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Feb 11, 2014 at 12:37:09AM +0000, Dilger, Andreas wrote: > On 2014/02/10, 2:29 PM, "Al Viro" wrote: > >On Mon, Feb 10, 2014 at 08:16:52PM +0000, Dilger, Andreas wrote: > >> >>Instead of trying to find a non-conflicting O_LOV_DELAY_CREATE flag > >> >>or define a Lustre-specific flag that isn't of use to most/any other > >> >>filesystems, use (O_NOCTTY|FASYNC) as the new value. These flag > >> >>are not meaningful for newly-created regular files and should be > >> >>OK since O_LOV_DELAY_CREATE is only meaningful for new files. > > > >*shrug* > > > >I can live with that; it's a kludge, but it's less broken than that > >explicit constant - that one is a non-starter, since O_... flag > >values are arch-dependent. > > Greg, > could you please merge the original patch. We'd like to get this into > our pending release of the Lustre user tools and into the releases for > older kernels (which will support both the old and new flags until the > support for older kernels is removed). Can you please resend the original patch, without the "RFC" line in the subject, so I know to apply it now? thanks, greg k-h