From: Jens Axboe <axboe@kernel.dk>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Kent Overstreet <kmo@daterainc.com>,
clm@fb.com, linux-fsdevel@vger.kernel.org, neilb@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix cloning of discard/write same bios
Date: Tue, 11 Feb 2014 08:41:07 -0700 [thread overview]
Message-ID: <20140211154107.GD19057@kernel.dk> (raw)
In-Reply-To: <20140211122216.GE1346@redhat.com>
On Tue, Feb 11 2014, Richard W.M. Jones wrote:
> On Mon, Feb 10, 2014 at 05:45:50PM -0800, Kent Overstreet wrote:
> > Immutable biovecs changed the way bio segments are treated in such a way that
> > bio_for_each_segment() cannot now do what we want for discard/write same bios,
> > since bi_size means something completely different for them.
> >
> > Fortunately discard and write same bios never have more than a single biovec, so
> > bio_for_each_segment() is unnecessary and not terribly meaningful for them, but
> > we still have to special case them in a few places.
> >
> > Signed-off-by: Kent Overstreet <kmo@daterainc.com>
>
> Tested-by: Richard W.M. Jones <rjones@redhat.com>
>
> I have confirmed this fixes the bug described here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1061339
Thanks, I have applied it for immediate inclusion.
--
Jens Axboe
prev parent reply other threads:[~2014-02-11 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 1:45 [PATCH] block: Fix cloning of discard/write same bios Kent Overstreet
2014-02-11 12:22 ` Richard W.M. Jones
2014-02-11 15:41 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211154107.GD19057@kernel.dk \
--to=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=kmo@daterainc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).