From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH RFC] block: use discard if possible in blkdev_issue_discard()
Date: Fri, 14 Feb 2014 05:05:13 -0800 [thread overview]
Message-ID: <20140214130513.GA6127@infradead.org> (raw)
In-Reply-To: <20140214043256.GA5145@thunk.org>
On Thu, Feb 13, 2014 at 11:32:56PM -0500, Theodore Ts'o wrote:
> 3) This functionality shouldn't be in the block device layer; if you
> want something like this, add it to fs/ext4 instead, and other file
> systems can optimize sb_issue_zeroout() themselves if they want.
>
> And if the answer is (1) or (2), do people mind if I carry this patch
> in the ext4 tree, so I can use and test this right away, without
> having to worry about merging with the block tree?
(4): add a new flag to blkdev_issue_zeroout to say if deallocating the
blocks is okay, and if yes proceed like (1).
Requiring blocks to be zeroed, but not wanting to remove the
provisioning seems like a perfectly valid request, especially from
userspace (e.g. databases)
next prev parent reply other threads:[~2014-02-14 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 4:32 [PATCH RFC] block: use discard if possible in blkdev_issue_discard() Theodore Ts'o
2014-02-14 13:05 ` Christoph Hellwig [this message]
2014-02-14 14:57 ` Theodore Ts'o
2014-02-14 17:14 ` Martin K. Petersen
2014-02-15 1:29 ` Theodore Ts'o
2014-02-17 16:44 ` Martin K. Petersen
2014-02-17 19:19 ` Theodore Ts'o
2014-02-18 1:31 ` Martin K. Petersen
2014-02-18 2:17 ` Theodore Ts'o
2014-02-18 3:44 ` Martin K. Petersen
2014-02-18 5:47 ` Theodore Ts'o
2014-02-19 2:20 ` Martin K. Petersen
2014-02-17 16:41 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214130513.GA6127@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).