From: Tejun Heo <tj@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Derek Basehore <dbasehore@chromium.org>,
Alexander Viro <viro@zento.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Kees Cook <keescook@chromium.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, bleung@chromium.org, sonnyrao@chromium.org,
semenzato@chromium.org
Subject: Re: [PATCH] backing_dev: Fix hung task on sync
Date: Wed, 19 Feb 2014 14:01:39 -0500 [thread overview]
Message-ID: <20140219190139.GQ10134@htj.dyndns.org> (raw)
In-Reply-To: <20140219092731.GA4849@quack.suse.cz>
Hello, Jan.
On Wed, Feb 19, 2014 at 10:27:31AM +0100, Jan Kara wrote:
> You are the workqueue expert so you may know better ;) But the way I
> understand it is that queue_delayed_work() does nothing if the timer is
> already running. Since we queue flusher work to run either immediately or
> after dirty_writeback_interval we are safe to run queue_delayed_work()
> whenever we want it to run after dirty_writeback_interval and
> mod_delayed_work() whenever we want to run it immediately.
Ah, okay, so it's always mod on immediate and queue on delayed. Yeah,
that should work.
> But it's subtle and some interface where we could say queue delayed work
> after no later than X would be easier to grasp.
Yeah, I think it'd be better if we had something like
mod_delayed_work_if_later(). Hmm...
Thanks.
--
tejun
next prev parent reply other threads:[~2014-02-19 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 4:12 [PATCH] backing_dev: Fix hung task on sync Derek Basehore
2014-02-17 9:20 ` Jan Kara
2014-02-18 22:55 ` Tejun Heo
2014-02-19 9:27 ` Jan Kara
2014-02-19 19:01 ` Tejun Heo [this message]
2014-03-11 18:23 ` Andrew Morton
2014-03-11 20:19 ` Jan Kara
2014-03-15 20:22 ` dbasehore .
2014-03-16 14:59 ` Tejun Heo
2014-03-16 19:13 ` dbasehore .
2014-03-16 20:20 ` dbasehore .
2014-03-17 14:40 ` Tejun Heo
2014-03-17 20:53 ` dbasehore .
2014-03-17 20:59 ` Tejun Heo
2014-03-17 9:53 ` Jan Kara
2014-02-19 15:31 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219190139.GQ10134@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bleung@chromium.org \
--cc=darrick.wong@oracle.com \
--cc=dbasehore@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=semenzato@chromium.org \
--cc=sonnyrao@chromium.org \
--cc=viro@zento.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).