From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Wong <normalperson@yhbt.net>
Subject: Re: [RFC PATCH for-next 1/4] epoll: struct epoll userspace definiton
Date: Mon, 24 Feb 2014 05:29:34 +0000
Message-ID: <20140224052934.GA7056@dcvr.yhbt.net>
References: <1393206162-18151-1-git-send-email-n1ght.4nd.d4y@gmail.com>
 <1393206162-18151-2-git-send-email-n1ght.4nd.d4y@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1393206162-18151-2-git-send-email-n1ght.4nd.d4y@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com> wrote:
> +++ b/include/uapi/linux/eventpoll.h
> @@ -61,6 +61,12 @@ struct epoll_event {
>  	__u64 data;
>  } EPOLL_PACKED;
>  
> +struct epoll {
> +	int ep_fildes; /* file descriptor */
> +	int ep_events; /* triggering events */
> +	long long ep_ident; /* entry ID (cf. epoll_event->data) */
> +} EPOLL_PACKED;

Why not reuse the existing epoll_event struct?

	struct epoll {
		int ep_fildes; /* file descriptor */
		struct epoll_event event;
	} EPOLL_PACKED;