From: Michal Hocko <mhocko@suse.cz>
To: Matthias Wirth <matthias.wirth@gmail.com>
Cc: Lukas Senger <lukas@fridolin.com>,
i4passt@lists.cs.fau.de,
Dave Hansen <dave.hansen@linux.intel.com>,
Matthew Wilcox <matthew@wil.cx>, Jeff Layton <jlayton@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Lisa Du <cldu@marvell.com>,
Minchan Kim <minchan@kernel.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Sasha Levin <sasha.levin@oracle.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jan Kara <jack@suse.cz>, Mel Gorman <mgorman@suse.de>,
Shaohua Li <shli@kernel.org>, Bob Liu <bob.liu@oracle.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Rafael Aquini <aquini@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Steven Whitehouse <swhiteho@redhat.
Subject: Re: [PATCHv3] mm: implement POSIX_FADV_NOREUSE
Date: Tue, 18 Mar 2014 16:14:48 +0100 [thread overview]
Message-ID: <20140318151448.GB8051@dhcp22.suse.cz> (raw)
In-Reply-To: <1394812370-13454-1-git-send-email-matthias.wirth@gmail.com>
On Fri 14-03-14 16:52:38, Matthias Wirth wrote:
[...]
> The idea of the patch is to add pages from files with FMODE_NOREUSE at
> the tail of the lru list. Therefore these pages are the first to be
> reclaimed. We added add_to_page_cache_lru_tail and corresponding
> functions, complementing add_to_page_cache_lru.
If this is set before the read then you can end up trashing on those
pages during heavy memory pressure I am afraid. Page would get reclaimed
before the read gets to it.
What you could do instead, I think, is to reclaim pages belonging to
a FMODE_NOREUSE file away when they would be activated normally during
reclaim. That would require tweaking page_check_references which
implements used-once logic currently.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-03-18 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:25 [PATCH] mm: implement POSIX_FADV_NOREUSE Matthias Wirth
2014-03-11 14:06 ` Michal Hocko
2014-03-11 15:24 ` Dave Hansen
2014-03-11 21:27 ` Andrew Morton
2014-03-12 11:59 ` Lukas Senger
2014-03-12 14:46 ` Michal Hocko
2014-03-12 16:05 ` Dave Hansen
2014-03-13 12:40 ` Lukas Senger
2014-03-13 18:43 ` [PATCHv2] " Matthias Wirth
2014-03-13 20:01 ` Andrew Morton
2014-03-14 12:34 ` Lukas Senger
2014-03-14 15:52 ` [PATCHv3] " Matthias Wirth
2014-03-18 15:14 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318151448.GB8051@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=bfields@fieldses.org \
--cc=bob.liu@oracle.com \
--cc=cldu@marvell.com \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=i4passt@lists.cs.fau.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lukas@fridolin.com \
--cc=matthew@wil.cx \
--cc=matthias.wirth@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=shli@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=swhiteho@redhat. \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).