linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Jan Kara <jack@suse.cz>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: bdi has dirty inode after umount of ext4 fs in 3.4.83
Date: Tue, 25 Mar 2014 18:09:38 -0400	[thread overview]
Message-ID: <20140325220938.GX4173@kvack.org> (raw)
In-Reply-To: <20140323131416.GD2813@quack.suse.cz>

On Sun, Mar 23, 2014 at 02:14:16PM +0100, Jan Kara wrote:
>   So the dirty inode is almost certainly a block device inode. Another clue
> is that fsync(2) actually doesn't clean inode dirty state (especially not
> for block device inodes since that inode is a special one and fs usually
> doesn't get to inspecting it). sync(2) does in general clear inode dirty
> state because that's handled by flusher thread. However if ->sync_fs()
> dirties the block device inode, subsequent sync_blockdev() call only writes
> the data but doesn't clean the inode state. So even with sync(2) it can
> happen the block device inode remains dirty.

> In general inode dirty state isn't reliable. I_DIRTY_DATA can be set when
> inode is in fact clean. You have to use mapping_tagged(inode->i_mapping,
> PAGECACHE_TAG_DIRTY) to determine whether the inode has actually any dirty
> data.

That is indeed the case.  I checked the contents of the inode, and none of 
the buffers attached to that inode were dirty.

Is there any desire to fix this?  Seeing an inode on the b_dirty list that 
isn't really an inode that contains any data doesn't make a whole lot of 
sense.

		-ben
-- 
"Thought is the essence of where you are now."

  reply	other threads:[~2014-03-25 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 15:25 bdi has dirty inode after umount of ext4 fs in 3.4.83 Benjamin LaHaise
2014-03-23 13:14 ` Jan Kara
2014-03-25 22:09   ` Benjamin LaHaise [this message]
2014-03-26  5:32     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325220938.GX4173@kvack.org \
    --to=bcrl@kvack.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).