From: "Richard W.M. Jones" <rjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>, linux-fsdevel@vger.kernel.org
Subject: Re: Making discard/fstrim reliable
Date: Thu, 3 Apr 2014 19:08:39 +0100 [thread overview]
Message-ID: <20140403180839.GR1302@redhat.com> (raw)
In-Reply-To: <533DA127.5090909@redhat.com>
On Thu, Apr 03, 2014 at 07:57:59PM +0200, Paolo Bonzini wrote:
> From Richard's description, what seems to happen is that ext4 FITRIM
> scans the filesystem and prepares the discard requests; but then it
> sends them down to the filesystem after the ioctl has finished.
> Does that make any sense? And would that be considered a bug?
That would account for it if it happened.
I'm still working on a good reproducer. It's remarkably hard to
reproduce on fast / 64 bit hardware ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/
prev parent reply other threads:[~2014-04-03 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 20:47 Making discard/fstrim reliable Richard W.M. Jones
2014-04-02 18:18 ` Jeff Moyer
2014-04-02 18:59 ` Richard W.M. Jones
2014-04-02 20:02 ` Jeff Moyer
2014-04-02 20:26 ` Richard W.M. Jones
2014-04-10 15:05 ` Richard W.M. Jones
2014-04-03 17:08 ` Lukáš Czerner
2014-04-03 17:23 ` Richard W.M. Jones
2014-04-03 17:57 ` Paolo Bonzini
2014-04-03 18:08 ` Richard W.M. Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403180839.GR1302@redhat.com \
--to=rjones@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).