From: Christoph Hellwig <hch@infradead.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: Viro <viro@zeniv.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
jack <jack@suse.cz>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] FS: Add generic data flush to fsync
Date: Fri, 11 Apr 2014 00:45:22 -0700 [thread overview]
Message-ID: <20140411074522.GA15518@infradead.org> (raw)
In-Reply-To: <20140411065242.42916952dd5d8e4e53848b3b@skynet.be>
On Fri, Apr 11, 2014 at 06:52:42AM +0200, Fabian Frederick wrote:
> Currently, there's no generic HW flush management support in kernel.
> Only 7 filesystems have their own way to manage the barrier flag.
>
> This patch adds MS_BARRIER in sb_flags and conditionnaly issues the flush
> in generic_file_fsync.
Please don't add a binary mount option for something thast already is a
text option in many filesystems. We can actually enable/disable cache
flushes at the block device level, so I think this can be
unconditional.
next prev parent reply other threads:[~2014-04-11 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 4:52 [PATCH 1/1] FS: Add generic data flush to fsync Fabian Frederick
2014-04-11 7:45 ` Christoph Hellwig [this message]
2014-04-11 13:00 ` Jan Kara
2014-04-11 21:05 ` Fabian Frederick
2014-04-14 7:22 ` Christoph Hellwig
2014-04-15 17:04 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411074522.GA15518@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).