From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/1] FS: Add generic data flush to fsync
Date: Fri, 11 Apr 2014 00:45:22 -0700
Message-ID: <20140411074522.GA15518@infradead.org>
References: <20140411065242.42916952dd5d8e4e53848b3b@skynet.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Viro <viro@zeniv.linux.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	jack <jack@suse.cz>, akpm <akpm@linux-foundation.org>
To: Fabian Frederick <fabf@skynet.be>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20140411065242.42916952dd5d8e4e53848b3b@skynet.be>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Fri, Apr 11, 2014 at 06:52:42AM +0200, Fabian Frederick wrote:
> Currently, there's no generic HW flush management support in kernel.
> Only 7 filesystems have their own way to manage the barrier flag.
> 
> This patch adds MS_BARRIER in sb_flags and conditionnaly issues the flush
> in generic_file_fsync.

Please don't add a binary mount option for something thast already is a
text option in many filesystems.  We can actually enable/disable cache
flushes at the block device level, so I think this can be
unconditional.