From: Al Viro <viro@ZenIV.linux.org.uk>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Chris Mason <clm@fb.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] odd thing in btrfs_file_aio_write()
Date: Mon, 14 Apr 2014 03:48:30 +0100 [thread overview]
Message-ID: <20140414024830.GR18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <534B495C.6060504@cn.fujitsu.com>
On Mon, Apr 14, 2014 at 10:35:08AM +0800, Qu Wenruo wrote:
> Oh, that's my fault, I forgot that iov can be chained.
>
> I should use 'pos + count' instead.
BTW, will there be any difference if 10Mb write starts one byte before EOF?
IOW, is that if (start_pos > i_size_read(inode)) { in there correct
these days? And what'll happen if we hit e.g. an unmapped page in the
middle of the data being written? That will result in short write, but
will it truncate what's left of that dummy range?
next prev parent reply other threads:[~2014-04-14 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 0:26 [RFC] odd thing in btrfs_file_aio_write() Al Viro
2014-04-14 2:35 ` Qu Wenruo
2014-04-14 2:48 ` Al Viro [this message]
2014-04-14 3:36 ` Qu Wenruo
2014-04-14 5:08 ` Al Viro
2014-04-14 7:21 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414024830.GR18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).