From: Christoph Hellwig <hch@infradead.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: Christoph Hellwig <hch@infradead.org>,
Viro <viro@zeniv.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
jack <jack@suse.cz>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] FS: Add generic data flush to fsync
Date: Mon, 14 Apr 2014 00:22:42 -0700 [thread overview]
Message-ID: <20140414072242.GE7860@infradead.org> (raw)
In-Reply-To: <20140411230530.984a9d57b3dec487af936d29@skynet.be>
On Fri, Apr 11, 2014 at 11:05:30PM +0200, Fabian Frederick wrote:
> Ok, that would mean 'older' filesystems -without barrier flag-
> to call generic_file_fsync would result in a flush but ext4 without journal
> also calls it ; maybe with nobarrier and I'm not sure it's the only case.
> How can I deal with this problem ?
I don't really think not implementing the barrier option is a problem.
For ext4 if you want consistency either opencode generic_file_fsync
there and add the check, or add a __generic_file_fsync that doesn't
do the flush.
next prev parent reply other threads:[~2014-04-14 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 4:52 [PATCH 1/1] FS: Add generic data flush to fsync Fabian Frederick
2014-04-11 7:45 ` Christoph Hellwig
2014-04-11 13:00 ` Jan Kara
2014-04-11 21:05 ` Fabian Frederick
2014-04-14 7:22 ` Christoph Hellwig [this message]
2014-04-15 17:04 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414072242.GE7860@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).