From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 2/4] xfs: initialize inode security on tmpfile creation
Date: Tue, 15 Apr 2014 10:50:33 -0700
Message-ID: <20140415175033.GB26404@infradead.org>
References: <1397578706-5385-1-git-send-email-bfoster@redhat.com>
 <1397578706-5385-3-git-send-email-bfoster@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: xfs@oss.sgi.com, linux-security-module@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: Brian Foster <bfoster@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.9]:48179 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751286AbaDORue (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 15 Apr 2014 13:50:34 -0400
Content-Disposition: inline
In-Reply-To: <1397578706-5385-3-git-send-email-bfoster@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Apr 15, 2014 at 12:18:24PM -0400, Brian Foster wrote:
> +	error = xfs_init_security(inode, dir, &dentry->d_name);
> +	if (unlikely(error)) {
> +		iput(inode);
> +		return -error;
> +	}
> +
>  	d_tmpfile(dentry, inode);
>  

I'd really love to hear from the LSM people who they plan to deal with
O_TMPFILE inodes.    But given that this seems to fix a real life bug
let's go with it for now.