From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Lukas Czerner <lczerner@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file
Date: Tue, 15 Apr 2014 22:51:34 -0400 [thread overview]
Message-ID: <20140416025134.GB21807@thunk.org> (raw)
In-Reply-To: <20140415220220.GR15995@dastard>
On Wed, Apr 16, 2014 at 08:02:20AM +1000, Dave Chinner wrote:
> On Tue, Apr 15, 2014 at 06:41:15PM +0200, Lukas Czerner wrote:
> > Currently punch hole and collapse range fallocate operation are not
> > allowed on append only file. This should be case for zero range as well.
> > Fix it by allowing only pure fallocate (possibly with keep size set).
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, updated with Dave's suggested added parenthesis.
- Ted
next prev parent reply other threads:[~2014-04-16 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 16:41 [PATCH 1/3 v2] ext4: Remove unnecessary check for APPEND and IMMUTABLE Lukas Czerner
2014-04-15 16:41 ` [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file Lukas Czerner
2014-04-15 22:02 ` Dave Chinner
2014-04-16 2:51 ` Theodore Ts'o [this message]
2014-04-16 8:29 ` Lukáš Czerner
2014-04-15 16:41 ` [PATCH 3/3 v2] fs: move falloc collapse range check into the filesystem methods Lukas Czerner
2014-04-16 2:55 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416025134.GB21807@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).