From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] Sync only the requested range in msync Date: Wed, 23 Apr 2014 07:11:15 -0700 Message-ID: <20140423141115.GA31375@infradead.org> References: <1395961361-21307-1-git-send-email-matthew.r.wilcox@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, willy@linux.intel.com To: Matthew Wilcox Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:35463 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbaDWOLS (ORCPT ); Wed, 23 Apr 2014 10:11:18 -0400 Content-Disposition: inline In-Reply-To: <1395961361-21307-1-git-send-email-matthew.r.wilcox@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 27, 2014 at 07:02:41PM -0400, Matthew Wilcox wrote: > [untested. posted because it keeps coming up at lsfmm/collab] > > msync() currently syncs more than POSIX requires or BSD or Solaris > implement. It is supposed to be equivalent to fdatasync(), not fsync(), > and it is only supposed to sync the portion of the file that overlaps > the range passed to msync. > > If the VMA is non-linear, fall back to syncing the entire file, but we > still optimise to only fdatasync() the entire file, not the full fsync(). > > Signed-off-by: Matthew Wilcox Looks good, Reviewed-by: Christoph Hellwig