From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Subject: Re: [PATCH] aio: Fix type of iterator variable in do_io_submit() Date: Wed, 23 Apr 2014 10:24:59 -0500 Message-ID: <20140423152459.GA7609@zzz.student-wireless05.macalester.edu> References: <1398207423-21119-1-git-send-email-ebiggers3@gmail.com> <20140423141617.GE13050@linux.intel.com> <20140423144237.GY22552@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Matthew Wilcox , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org To: Benjamin LaHaise Return-path: Content-Disposition: inline In-Reply-To: <20140423144237.GY22552@kvack.org> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Apr 23, 2014 at 10:42:37AM -0400, Benjamin LaHaise wrote: > Practically speaking, this change has no effect. The io_submit() syscall > will exit far before we even hit INT_MAX because of the limits on the > number of iocbs. Yes it looks like it doesn't actually make a difference due to the default 'aio-max-nr' limit of 1048576 (although you actually can submit just over twice this many). In my opinion this change should still be made so that the correctness of the code doesn't rely on that nonlocal assumption, however. And/or the explicit limit of (LONG_MAX / sizeof(struct iocb *)) elements could be changed to something lower, as Matthew suggested. Eric -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org